-
Notifications
You must be signed in to change notification settings - Fork 13
Backend: Add unit tests #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
luarss
merged 10 commits into
The-OpenROAD-Project:master
from
luarss:topic/add-unit-tests
Jul 11, 2025
Merged
Backend: Add unit tests #163
luarss
merged 10 commits into
The-OpenROAD-Project:master
from
luarss:topic/add-unit-tests
Jul 11, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Song Luar <[email protected]>
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds comprehensive tests and updates test configuration to improve backend reliability.
- Introduces extensive unit and integration tests for chains (Similarity, MMR, Hybrid, BM25, BaseChain), document processing utilities (PDF, MD, HTML, JSON), formatting, chunking, vector store, and API healthcheck.
- Updates test dependencies and pytest configuration (
requirements-test.txt,pyproject.toml) and adds atesttarget to the Makefile and CI workflows. - Provides sample test data (Markdown) and shared fixtures in
conftest.py.
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/tests/*.py | New tests covering chains, tools, and API |
| backend/tests/data/sample.md | Sample Markdown fixture |
| backend/tests/conftest.py | Shared fixtures and test environment setup |
| backend/requirements-test.txt | Added pytest and plugins |
| backend/pyproject.toml | Configured pytest options and coverage settings |
| backend/Makefile | Added test target |
| .github/workflows/ci.yaml | Added make test step |
| .github/workflows/ci-secret.yaml | Added make test step |
Comments suppressed due to low confidence (1)
backend/pyproject.toml:98
- pytest is configured to look under
tests, but your tests live inbackend/tests. Updatetestpathsto includebackend/testsor relocate the test directory.
testpaths = ["tests"]
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.