Skip to content

Conversation

@luarss
Copy link
Collaborator

@luarss luarss commented Jul 7, 2025

No description provided.

luarss added 3 commits July 7, 2025 16:50
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Copilot AI review requested due to automatic review settings July 7, 2025 16:59

This comment was marked as outdated.

@luarss luarss requested a review from Copilot July 7, 2025 17:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds comprehensive tests and updates test configuration to improve backend reliability.

  • Introduces extensive unit and integration tests for chains (Similarity, MMR, Hybrid, BM25, BaseChain), document processing utilities (PDF, MD, HTML, JSON), formatting, chunking, vector store, and API healthcheck.
  • Updates test dependencies and pytest configuration (requirements-test.txt, pyproject.toml) and adds a test target to the Makefile and CI workflows.
  • Provides sample test data (Markdown) and shared fixtures in conftest.py.

Reviewed Changes

Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
backend/tests/*.py New tests covering chains, tools, and API
backend/tests/data/sample.md Sample Markdown fixture
backend/tests/conftest.py Shared fixtures and test environment setup
backend/requirements-test.txt Added pytest and plugins
backend/pyproject.toml Configured pytest options and coverage settings
backend/Makefile Added test target
.github/workflows/ci.yaml Added make test step
.github/workflows/ci-secret.yaml Added make test step
Comments suppressed due to low confidence (1)

backend/pyproject.toml:98

  • pytest is configured to look under tests, but your tests live in backend/tests. Update testpaths to include backend/tests or relocate the test directory.
testpaths = ["tests"]

luarss added 6 commits July 7, 2025 17:49
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
Signed-off-by: Jack Luar <[email protected]>
@luarss luarss merged commit 8cb1ec0 into The-OpenROAD-Project:master Jul 11, 2025
2 checks passed
@luarss luarss deleted the topic/add-unit-tests branch July 11, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant